memory: guard indirect autoconfig RAM allocation

mapped_malloc() uses labels starting with "*" for indirect allocations.
Those allocations require a fixed start address.

Only enter that path when the caller opted in with canbang. This keeps
ordinary mappings from following that path because of label text alone.

diff --git a/memory.cpp b/memory.cpp
index 6d3d038f656e89a3df11e73a577e6851b467cd93..bb4b61ec4b5801cb51543128bdd9cf6b5c5b469f 100644 (file)
--- a/memory.cpp
+++ b/memory.cpp
@@ -2332,7 +2332,7 @@ bool mapped_malloc (addrbank *ab)
        ab->baseaddr_direct_w = NULL;
        ab->flags &= ~ABFLAG_MAPPED;
 
-       if (ab->label && ab->label[0] == '*') {
+       if (canbang && ab->label && ab->label[0] == '*') {
                if (ab->start == 0 || ab->start == 0xffffffff) {
                        write_log(_T("mapped_malloc(*) without start address!\n"));
                        return false;