From: trevor_hansen <trevor_hansen@e59a4935-1847-0410-ae03-e826735625c1>
Date: Sat, 3 Mar 2012 12:16:56 +0000 (+0000)
Subject: Improvement. Extra rewrite rules.
X-Git-Url: https://git.unchartedbackwaters.co.uk/w/?a=commitdiff_plain;h=e51803611f934dd2463d0151d057dc36c0f7e21f;p=francis%2Fstp.git

Improvement. Extra rewrite rules.

git-svn-id: https://stp-fast-prover.svn.sourceforge.net/svnroot/stp-fast-prover/trunk/stp@1580 e59a4935-1847-0410-ae03-e826735625c1
---

diff --git a/src/AST/NodeFactory/SimplifyingNodeFactory.cpp b/src/AST/NodeFactory/SimplifyingNodeFactory.cpp
index 45871f3..976953d 100644
--- a/src/AST/NodeFactory/SimplifyingNodeFactory.cpp
+++ b/src/AST/NodeFactory/SimplifyingNodeFactory.cpp
@@ -1295,6 +1295,9 @@ SimplifyingNodeFactory::CreateTerm(Kind kind, unsigned int width, const ASTVec &
     break;
 
   case SBVMOD:
+    {
+      const ASTNode max = bm.CreateMaxConst(width);
+
     if (children[1].isConstant() && CONSTANTBV::BitVector_is_empty(children[1].GetBVConst()))
       result = children[0];
     else if (children[0] == children[1])
@@ -1309,6 +1312,14 @@ SimplifyingNodeFactory::CreateTerm(Kind kind, unsigned int width, const ASTVec &
       result = bm.CreateZeroConst(width);
     else if (children[1].GetKind() == BVUMINUS && children[1][0] == children[0])
       result = bm.CreateZeroConst(width);
+    else if ( width >= 4 && children[0].GetKind() == BVNEG && children[1] == children[0][0] )
+      result = bm.CreateTerm(SBVMOD,width,max,children[0][0]);//9759 -> 542 | 4842 ms
+    else if ( width >= 4 && children[1].GetKind() == BVNEG && children[1][0] == children[0] )
+      result =  bm.CreateTerm(SBVMOD,width,max,children[1]);//9759 -> 542 | 4005 ms
+    else if ( width >= 4 &&  children[0].GetKind() == BVNEG && children[1].GetKind() == BVUMINUS && children[1][0] == children[0][0] )
+      result =  bm.CreateTerm(SBVMOD,width,max,children[1]);//9807 -> 674 | 2962 ms
+    }
+
     break;
 
   case BEEV::BVDIV:
@@ -1349,6 +1360,11 @@ SimplifyingNodeFactory::CreateTerm(Kind kind, unsigned int width, const ASTVec &
     break;
 
   case SBVREM:
+    {
+      const ASTNode one = bm.CreateOneConst(width);
+          const ASTNode zero = bm.CreateZeroConst(width);
+          const ASTNode max = bm.CreateMaxConst(width);
+
     if (children[0] == children[1])
       result = bm.CreateZeroConst(width);
     else if (children[0].isConstant() && CONSTANTBV::BitVector_is_empty(children[0].GetBVConst()))
@@ -1363,9 +1379,18 @@ SimplifyingNodeFactory::CreateTerm(Kind kind, unsigned int width, const ASTVec &
       result = NodeFactory::CreateTerm(SBVREM, width, children[0], children[1][0]);
     else if (children[0].GetKind() == BVUMINUS && children[0][0] == children[1])
       result = bm.CreateZeroConst(width);
+    else if ( width >= 4 &&  children[0].GetKind() == BVNEG && children[1] == children[0][0] )
+      result =  bm.CreateTerm(BVUMINUS,width,bm.CreateTerm(SBVMOD,width,one,children[0][0]));//9350 -> 624 | 3072 ms
+    else if ( width >= 4 &&  children[1].GetKind() == BVNEG && children[1][0] == children[0] )
+      result =  bm.CreateTerm(BVUMINUS,width,bm.CreateTerm(SBVMOD,width,one,children[1]));//9350 -> 624 | 2402 ms
+    else if ( width >= 4 &&  children[0].GetKind() == BVUMINUS && children[1] == max)
+      result =  bm.CreateTerm(BVUMINUS,width,bm.CreateTerm(SBVREM,width,children[0][0],children[1]));//123 -> 83 | 1600 ms
+    }
+
+
     break;
 
-  case BEEV::BVMOD:
+  case BVMOD:
     {
       if (children[0] == children[1])
         result = bm.CreateZeroConst(width);
@@ -1398,6 +1423,8 @@ SimplifyingNodeFactory::CreateTerm(Kind kind, unsigned int width, const ASTVec &
       if ( width >= 3 && children[1].GetKind() == BVNEG && children[1][0] == children[0] )
         result =  NodeFactory::CreateTerm(BVMOD,width,bm.CreateMaxConst(width),children[1]);//3285 -> 3113
 
+      if ( width >= 4 && children[0].GetKind() == BVUMINUS && children[1].GetKind() == BVNEG && children[1][0] == children[0][0] )
+        result  =   NodeFactory::CreateTerm(SBVREM,width,one,children[1]); //8883 -> 206 | 1566 ms
     }
 
     break;